gh-145719: Add .efi file detection in mimetypes#145720
Open
clin1234 wants to merge 6 commits intopython:mainfrom
Open
gh-145719: Add .efi file detection in mimetypes#145720clin1234 wants to merge 6 commits intopython:mainfrom
.efi file detection in mimetypes#145720clin1234 wants to merge 6 commits intopython:mainfrom
Conversation
Contributor
Author
|
@aisk, mind reviewing my PR? |
Contributor
Author
|
@hugovk, mind reviewing this PR as well? |
Member
|
Hi, please don't be too pushy and mention people to review the PR immediately. Python is an open source project and most maintainers are using their spare time to do the work. |
hugovk
reviewed
Mar 12, 2026
Member
hugovk
left a comment
hugovk
left a comment
There was a problem hiding this comment.
Confirming IANA reg: https://www.iana.org/assignments/media-types/application/efi
@clin1234 Please could you follow the same pattern as #145718?
- No need for test if it's repeating the MIME type. Useful tests are for when we're testing priority of multiple extensions, or some new code path/logic.
- Add to What's New.
Thanks.
Misc/NEWS.d/next/Library/2026-03-10-01-54-34.gh-issue-145719.okJRoK.rst
Outdated
Show resolved
Hide resolved
…kJRoK.rst Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source: iana.org/assignments/media-types/application/efi
.efifile detection inmimetypes#145719